Skip to content

Develop logger improve #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Develop logger improve #1285

merged 1 commit into from
Oct 4, 2018

Conversation

xiaomaogy
Copy link
Contributor

No description provided.

@xiaomaogy xiaomaogy changed the base branch from master to develop October 4, 2018 01:45
@xiaomaogy
Copy link
Contributor Author

Context around this change:

logging.basicConfig will use the first config that gets set, so in environment.py, if it has
from .rpc_communicator import RpcCommunicator. It will use the logging level within the rpc_communicator and never change that. Since all of the communicator class will always be used by environment, I think just keep it in one place to control the logging level makes more sense.

@vincentpierre
Copy link
Contributor

Not sure if this should actually be exposed through the command line.

@xiaomaogy
Copy link
Contributor Author

xiaomaogy commented Oct 4, 2018 •
edited
Loading

Yes I think so, I will add the command line control for this in another PR.

@xiaomaogy xiaomaogy merged commit 637839f into develop Oct 4, 2018
@xiaomaogy xiaomaogy deleted the develop-logger-improve branch October 4, 2018 17:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@vincentpierre vincentpierre vincentpierre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaomaogy @vincentpierre