add make.bat for windows #1272
Merged
add make.bat for windows #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomaogy
suggested changes
Oct 10, 2018
|
|
||
| rem GRPC-TOOLS required. Install with `nuget install Grpc.Tools`. | ||
| rem Then un-comment and replace [DIRECTORY] with location of files. | ||
| rem For example, on macOS, you might have something like: |
There was a problem hiding this comment.
This should be "on Windows" instead of on macOS.
| rem Then un-comment and replace [DIRECTORY] with location of files. | ||
| rem For example, on macOS, you might have something like: | ||
| rem COMPILER=Grpc.Tools.1.14.1/tools/windows_x64 | ||
| rem set COMPILER=[DIRECTORY] |
There was a problem hiding this comment.
Change this to
rem set COMPILER=Grpc.Tools.1.14.1/tools/windows_x64
| rem Then un-comment and replace [DIRECTORY] with location of files. | ||
| rem For example, on macOS, you might have something like: | ||
| rem COMPILER=Grpc.Tools.1.14.1/tools/windows_x64 | ||
| rem set COMPILER=[DIRECTORY] |
There was a problem hiding this comment.
remove this:
rem set COMPILER=[DIRECTORY]
|
@YuMurata Overall looks good to me. I've successfully used your script to generate the protobuf on windows. If you could spend some time resolve these minor comments, then I'm happy to merge it in. |
|
thanks for comment. |
|
@YuMurata Thank you for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.