Skip to content

Use organized tags for tensorboard stats #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2018
Merged

Use organized tags for tensorboard stats #1248

merged 5 commits into from
Oct 10, 2018

Conversation

awjuliani
Copy link
Contributor

@awjuliani awjuliani commented Sep 20, 2018 •
edited
Loading

Replace single Info tag with Environment, Policy, and Losses tags to organize information in Tensorboard better. Each group can be independently collapsed to reduce visual clutter as well.

screen shot 2018-09-20 at 10 59 33 am

Todo:

  • Update documentation
  • Make changes to Behavioral Cloning (pending merging demonstration recorder into develop)

@vincentpierre
Copy link
Contributor

Why is this PR pending on demonstration recorder ?
Why not merge it in now (with new docs) ?

@awjuliani
Copy link
Contributor Author

Updated documentation. This PR is now ready for review.

@awjuliani awjuliani requested a review from xiaomaogy October 9, 2018 23:53
xiaomaogy
xiaomaogy approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@xiaomaogy xiaomaogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge. I've checked all of the documentation to make sure tensorboard relevant docs are updated properly.

@awjuliani awjuliani merged commit 175a177 into develop Oct 10, 2018
@awjuliani awjuliani deleted the develop-tb-org branch October 10, 2018 00:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@xiaomaogy xiaomaogy xiaomaogy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awjuliani @vincentpierre @xiaomaogy