Develop scriptable brains ball scene #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
vincentpierre
added a commit
that referenced
this pull request
Oct 5, 2018
* Initial Commit Ported most functionalities, still need to : - Documentation - Add Comments - Custom drawer for BrainParameters - Fix the UnitTests - Review Functionalities * Added Custom Drawer for the Brain Parameters * Improvements to the HubDrawer * Modified the Brain Editors * Minor bug fixes and UI changes * Modified the Help Boxes of the Drawers * Modified Brain class, renamed Initialize and made DecideAction virtual * Fix the UnityTests * Simpler Brain creation menu * Renamed Internal Brain to Learning Brain * modified the parameters to remove reference to External or Internal in the Protobuf objects * Updated the protobuf generated files * Fix the Pytests * Removed the graph scope from the Learning Brain * cleaner logic than try catch * Removed the isExternal field of the brain and put the isTraining logic into LearningBrain and Training Hub * Modified how the Brain finds the Academy * Removed refences to CoreBrain * Fix import bug * Addressed some comments * Remove useless imports * Added nice icons for the brains * Added a feature to deepcopy brain parameters between brains * Resolve drawer bug * Develop scriptable brains ball scene (#1233) * Created the Brains for the Ballance Ball Environment * Modified the Balance Ball Scene * Renamed Training Hub to Broadcast Hub * Added a comment * renamed SetToControlled to SetControlledExternally in the Learning Brain * Resolved errors in case ENABLE_TENSORFLOW is not activated * Update the BalanceBall Scene * Refactored the BrainParameters drawer * Addressed offline comments * Comments on the ResetParametersDrawer * refactired the BroadcastHubDrawer * Adding comments * Add comment on the horizontal bar * Added new comments * Refactor of the Editors * minor changes * Added documentation, Fixed a bug in the tenporary internal brain when TF# is disabled * Develop scriptable brains documentation (#1249) * Modified first docs * modified the markdown, not the images * Missing doc * Replaced Internal with Learned Brain * updated the images * Addressed some comments * Renamed Training Hub to Broadcast Hub * Forgot one file * Added new images * addressing comment * Fixed some typos * address comments on the code * addressed comments on documents * Resolving conflicts on the Learning Brain * Minor tweaks * Addressed Comments * Created a Clone method in the BrainParameters, created a new BrainParameters file, made a CumSum method * Added Unit Test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Balance Ball Scene with Scriptable Object Brains.
There are 3 platforms : The first uses internal, the second uses random heuristic and the last one is player controlled.
This PR is for feedback on :
Brainsfolder in theExamples/3DBallfolder