Skip to content

Conversation

sdiao
Copy link
Contributor

@sdiao sdiao commented Jun 8, 2021

Proposed change(s)

Update the ROS Topic to SourceDestination_input in the Pick and Place Demo. This is to make the rostopic list and validation message returns the same topic name.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Original discussion in:
#224 (comment)
#224 (comment)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Tested with the pick and place quick demo. On ROS side, I verified that rostopic list returns SourceDestination_input instead of SourceDestination
Screen Shot 2021-06-08 at 10 49 00 AM

Test Configuration:

  • Unity Version: Unity 2020.2.4f1
  • Unity machine OS + version: macOs BigSur
  • ROS machine OS + version: ROS melodic
  • ROS–Unity communication: Docker

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works - Manual test
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@sdiao sdiao merged commit d52496c into dev Jun 8, 2021
peifeng-unity pushed a commit that referenced this pull request Jul 16, 2021
* AIRO-687 Update ROS topic to SourceDestination_input for pick and place demo

* Update CHANGELOG.md
@sdiao sdiao deleted the shuo/update-ros-topic branch July 30, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants