Skip to content

fix: add import to lensflare from three addons #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: add import to lensflare from three addons #585

wants to merge 22 commits into from

Conversation

alvarosabu
Copy link
Member

No description provided.

alvarosabu and others added 22 commits May 2, 2023 17:16
@alvarosabu
Merge pull request #18 from Tresjs/feature/17-reactive-3dtext-with-ne…
0506506 
…edupdates-props

feat: 17 reactive 3dtext with needupdates props
@alvarosabu
Merge branch 'main' into next
6ed4922
@alvarosabu
docs: un-comment back the new features
12e9748
@andretchen0 @alvarosabu
feat(Helper): add component, demo, docs (#543)
63535a2 
* feat(Helper): add component, demo, docs

* refactor(useHelper): use destructuring

* refactor(useHelper): remove

---------

Co-authored-by: Alvaro Saburido <[email protected]>
@andretchen0 @alvarosabu
feat(PointMaterial): add component, demo, docs (#545)
4528f64 
* feat(PointMaterial): add component, demo, docs

* chore: lint

* refactor: remove unused function argument

* feat: deconstruct points material imports

---------

Co-authored-by: alvarosabu <[email protected]>
@andretchen0
feat(ScreenQuad): add component, playground, docs (#530)
34a3db5
@andretchen0 @alvarosabu
feat(MarchingCubes): add component, demo, docs (#553)
2ebc1e6 
* feat(MarchingCubes): add component, demo, docs

* feat(MarchingCubes): add default material

* chore: lint

---------

Co-authored-by: alvarosabu <[email protected]>
@andretchen0
feat(CubicBezierLine): add component, demo, docs (#546)
99c3a60 
* feat(CubicBezierLine): add component, demo, docs

* docs: revert broken link
@andretchen0 @alvarosabu
feat(QuadraticBezierLine): add component, demo, docs (#548)
4a9f006 
Co-authored-by: alvarosabu <[email protected]>
@andretchen0
feat(AccumulativeShadows): add component, demo, docs (#558)
7e6b8d0 
* feat(AccumulativeShadows): add component, demo, docs

* refactor(RandomizedLights): rename interface

* refactor(AccumulativeShadows): change default alphaTest value

* refactor(AccumulativeShadows): expose update function
@andretchen0 @alvarosabu
feat(Bounds): add component, demo, docs (#408) (#568)
592ec68 
* feat(Bounds): add component, demo, docs

* refactor(Bounds): useScreenSize -> useResize

* refactor(Bounds): rename variables, remove unneeded state

* docs: fix material items merge issue

---------

Co-authored-by: alvarosabu <[email protected]>
@andretchen0
refactor(Align): change callback to emit, improve naming (#571)
789110e
@alvarosabu
Merge branch 'main' into next
32562b8
@andretchen0 @alvarosabu
feat(CircleShadow): add component, demo, docs (#549)
c0c1bcc 
* feat(CircleShadow): add component, demo, docs

* docs(CircleShadow): fix prop name

---------

Co-authored-by: alvarosabu <[email protected]>
@andretchen0 @alvarosabu
feat(Stage): add component, demo, docs (#572)
9db8c78 
* feat(AccumulativeShadows): add component, demo, docs

* feat(Bounds): add component, demo, docs

* refactor(Bounds): useScreenSize -> useResize

* refactor(Bounds): rename variables, remove unneeded state

* refactor(Align): change callback to emit, improve naming

* refactor(RandomizedLights): rename interface

* refactor(AccumulativeShadows): change default alphaTest value

* refactor(AccumulativeShadows): expose update function

* feat(Stage): add component, demo, docs

* docs: fix material items

* feat: import RandomizedLightsProps from correct file

* refactor(Stage): update types

---------

Co-authored-by: alvarosabu <[email protected]>
@andretchen0
chore(Outline): type material
000858f
@andretchen0 @alvarosabu
feat(LOD): add component, playground, docs (#524)
ef6438c 
Co-authored-by: Alvaro Saburido <[email protected]>
@alvarosabu
Merge branch 'main' into next
d34411a
@alvarosabu
refactor(Bounds): replace clamp import with MathUtils.clamp for consi…
59e1888 
…stency
@andretchen0 @alvarosabu
feat(useIntersect): add function, demo, docs (#550)
b0ba621 
Co-authored-by: alvarosabu <[email protected]>
@alvarosabu
chore: update dependencies in package.json and pnpm-lock.yaml
4da0c42 
- Bump versions for several dependencies including:
  - @vueuse/core from ^12.0.0 to ^12.3.0
  - three-stdlib from ^2.34.0 to ^2.35.2
  - eslint from ^9.16.0 to ^9.17.0
  - release-it from ^17.10.0 to ^18.0.0
  - typescript-eslint packages to ^8.19.0
  - Update various other dependencies to their latest versions for improved compatibility and performance.

- Update pnpm-lock.yaml to reflect the changes in package.json and ensure consistency across the project.
@alvarosabu
fix: add import to lensflare from three addons
b4d29e9
@alvarosabu alvarosabu requested a review from andretchen0 January 8, 2025 16:51
@alvarosabu alvarosabu self-assigned this Jan 8, 2025
@alvarosabu alvarosabu added the bug Something isn't working label Jan 8, 2025
@andretchen0
Copy link
Contributor

andretchen0 commented Jan 9, 2025 •
edited
Loading

I created this issue on three-stdlib:

pmndrs/three-stdlib#396

Until three-stdlib is fixed, how about sticking Lensflare.js from /examples/jsm in Cientos? That avoids build errors and works as expected.

@CodyJasonBennett
Copy link

CodyJasonBennett commented Jan 11, 2025 •
edited
Loading

I fixed the upstream issue but would suggest importing from three/addons if possible since this is an ESM-only package. The benefits of three-stdlib are to support CJS builds and offer backwards compatibility. In time, I hope to remove the need for the package entirely. three/addons (since r158) was a first step towards that.

three-stdlib does tree shake completely, where three/addons or three/examples/jsm/** does not. You can mitigate that with the latter (three/addons is impossible to tree-shake unfortunately; needs mrdoob/three.js#26912) by emitting separate JS files with preserveModules or similar and package.sideEffects = false, so bundlers won't include files unless referenced in code.

Importing from three/examples/jsm/** creates hazards since some bundlers require explicit file extensions, which can be lost during transpilation, as it is technically source code (e.g. mrdoob/three.js#24593).

Base automatically changed from next to main September 20, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andretchen0 andretchen0 Awaiting requested review from andretchen0

At least 1 approving review is required to merge this pull request.

Assignees

@alvarosabu alvarosabu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarosabu @andretchen0 @CodyJasonBennett