Skip to content

feat(Line2): allow points to be added/removed #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(Line2): allow points to be added/removed #551

wants to merge 12 commits into from

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Dec 2, 2024 •
edited
Loading

Problem

After initial creation, additional points could not be added to Cientos' Line2 component. The on-screen component would not display the additional points.

Solution

Recreate the Line2 geometry to accommodate the additional points.

Problem

The defineExposed instance is undefined because here ...

<template>
  <primitive
    :ref="lineRef"
    :object="line"
  />
</template>

... :ref should be ref.

Solution

Remove the colon from :ref.

Meta

Closes #493

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

❌ Deploy Preview for cientos-tresjs failed. Why did it fail? →

Name Link
🔨 Latest commit a1ffbd4
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/674e0a71c183450008896e23

@andretchen0 andretchen0 added the feature New feature or request label Dec 2, 2024
@andretchen0 andretchen0 marked this pull request as ready for review December 2, 2024 19:41
alvarosabu and others added 3 commits December 13, 2024 10:34
@alvarosabu
Merge branch 'main' into next
6ed4922
@alvarosabu
docs: un-comment back the new features
12e9748
@andretchen0 @alvarosabu
feat(Helper): add component, demo, docs (#543)
63535a2 
* feat(Helper): add component, demo, docs

* refactor(useHelper): use destructuring

* refactor(useHelper): remove

---------

Co-authored-by: Alvaro Saburido <[email protected]>
@andretchen0 andretchen0 changed the base branch from main to next December 14, 2024 09:26
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 14, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@551

commit: 0323e67

Base automatically changed from next to main September 20, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu Awaiting requested review from alvarosabu alvarosabu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line2，Modify props.points, but it does not take effect
2 participants
@andretchen0 @alvarosabu