This repository was archived by the owner on Nov 29, 2017. It is now read-only.
Make AMD module 'angular-logX' the main AMD module #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 7, 2014 13:22
If "angular-logX" is required only the module 'mindspace.logX' with the LogDecorator configured is created. If a custom app requires ExternalLogger it also has to require "mindspace/logger/ExternalLogger".
.Removed some incomplete and missleading comments.
Make 'angular-logX' a AMD module which, when required, creates and exports the Angular module with the configured logging decorator. Client's only need to require 'angular-logX' and put that module.name to their module's dependency list.
|
@k7sleeper - |
|
No! I'll try them ASAP. |
|
No, they do not run. The first 3 run well, but the next does not. It seems that the demos aren't up-to date. I had to fix an issue in |
renamed angularjs-logDecorator dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this PR, we'd have the situation:
This solution is not tainted with side-effects as the current solution is.