makefile warn undefined variables #726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ make install 2>&1 | pcregrep -o1 "undefined variable '(.*)'" | sort | uniq -c
2 CFLAGS
275 DESTDIR
15 GIT_BRANCH
1 GIT_VERSION
37 LUA_CPATH
37 LUA_PATH
15 path_to_src
15 PATH_TO_SRC
15 PKG_LFS
30 TAG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just enabled these warnings for my debian rules file while building Lmod, and I saw some warnings come out from Lmod's own makefile. It seems like a harmless addition, unless it breaks compatibility with old versions of make. I'm also not sure this is the right place to put it.