Skip to content

fixing the options doesn't update issue. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixing the options doesn't update issue. #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
509bfaf
fixing the options doesn't update issue.
itaibh Oct 10, 2016
8409953
a better update method.
itaibh Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion knockout-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
}.bind(undefined, e, viewModel, allBindings, options[e]);
});

var sortableElement = Sortable.create(element, options);
element._knockout_sortable = Sortable.create(element, options);

// Destroy the sortable if knockout disposes the element it's connected to
ko.utils.domNodeDisposal.addDisposeCallback(element, function () {
Expand All @@ -95,6 +95,13 @@
// There seems to be some problems with updating the options of a sortable
// Tested to change eventhandlers and the group options without any luck

var options = buildOptions(valueAccessor, sortableOptions);
var sortable = element._knockout_sortable;

for (var prop in options) {
sortable.option(prop, options[prop]);
}

return ko.bindingHandlers.template.update(element, valueAccessor, allBindings, viewModel, bindingContext);
},
eventHandlers = (function (handlers) {
Expand Down