Skip to content

Workspace symbols should include local modules #72

@kunos

Description

@kunos

In symbols.jai there's this comment:

// @todo: We only include project files, is this ok?
// TypeScript Language Server does this (filtering node_modules etc)
// Go Server does include "compiler" packages
// We should make more reseach on this topic and ask people around what they think
// and how they use this feature...

My answer would be no, it's very important to have local modules' symbols appear in the search.
So I would say this:

        // Skip files from local modules (we only want workspace project files)
        for local_module_folder: server.local_modules {
            full_local_module_folder_path := tprint("%/%", server.project_root, local_module_folder);

            if begins_with(file.path, full_local_module_folder_path) {
                continue file;
            }
        }

symbols.jai line 44
should go or, at the very least let's have it as configurable option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions