Skip to content

Update ESLint and ruin everyone's PRs #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update ESLint and ruin everyone's PRs #1471

wants to merge 14 commits into from

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Jun 15, 2025

I updated ESLint and used an updated version of the airbnb rules.

I disabled a lot of its rules and many of them I want to enable again but they would make the PR bigger than it already is 😭

@ImUrX ImUrX added Priority: High Important feature or blocks something important Type: Enhancement Adds or improves a feature labels Jun 15, 2025
@github-actions github-actions bot added the Area: GUI Related to the GUI label Jun 15, 2025
@ImUrX
Copy link
Member Author

ImUrX commented Jun 15, 2025

@loucass003 dont kill me pls 🥺

@ImUrX ImUrX added the Area: Continuous Integration Automated testing and deployment label Jun 15, 2025
ButterscotchV
ButterscotchV approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-config-airbnb-extended also has version 2.1.0 that just came out this week 👀

@ImUrX
Copy link
Member Author

ImUrX commented Jun 20, 2025

interesting, i didnt know. CI makes a merge of this PR with main before doing CI, which is obvious ofc but i never thought about it

@JovannMC
Copy link
Member

thanks, now i have to fix 100 merge conflicts on my non-existent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Continuous Integration Automated testing and deployment Area: GUI Related to the GUI Priority: High Important feature or blocks something important Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImUrX @JovannMC @ButterscotchV