Extract version managers from ruby-lsp #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
commented
Sep 23, 2025
Comment on lines
+39
to
+41
| const customBundleGemfile = vscode.workspace.getConfiguration("rubyLsp").get<string>("bundleGemfile"); | ||
|
|
||
| if (customBundleGemfile && customBundleGemfile.length > 0) { |
There was a problem hiding this comment.
I changed this part to handle undefined because this customBundleGemfile will be null when rubyLsp is not installed.
ono-max
force-pushed
the
extract-version-managers
branch
from
da78301 to
c2a3537
Compare
ono-max
commented
Sep 23, 2025
|
|
||
| export const asyncExec = promisify(exec); | ||
| export const RUBY_ENVIRONMENTS = "Ruby Environments"; | ||
| export const LOG_CHANNEL = window.createOutputChannel(RUBY_ENVIRONMENTS, { |
There was a problem hiding this comment.
I changed this name from "Ruby LSP" to "Ruby Environments"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2
As a first step, I extracted code related to version managers from ruby-lsp. Most code were extracted without any modifications.