Skip to content

Conversation

z-Fng
Copy link
Contributor

@z-Fng z-Fng commented Sep 26, 2025

This PR makes the following changes:

Closes:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • None.
  • Bug Fixes
    • Updated Windows download endpoints for x64, x86, and ARM64 to a consistent naming scheme in both direct downloads and autoupdate.
    • Prevents broken links and ensures smooth updates for installers, package managers, and scripts; versions and hashes remain unchanged with no in-app behavior changes.
  • Chores
    • Maintenance update to keep distribution links aligned across architectures.

Copy link

coderabbitai bot commented Sep 26, 2025

Walkthrough

Updated the download URL patterns in the Scoop manifest for zls-dev, changing from zls-windows-... to zls--windows-... across architecture entries and autoupdate. Hashes, versions, and other fields remain unchanged.

Changes

Cohort / File(s) Summary
Manifest URL pattern update
bucket/zls-dev.json
Switched URLs to use zls-<arch>-windows-... for x64, x86, and arm64 in both architecture and autoupdate blocks; no changes to hashes, version placeholders, or other fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at links that fail,
Hop-hop—new paths along the trail.
From windows-first to arch in front,
The downloads land without a punt.
Carrots cached, hashes true—
One neat hop, and through we zoom. 🥕🚀

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly summarizes the primary change by naming the manifest and version and stating the update to the URL and autoupdate settings following the repository’s conventional title format.
Linked Issues Check ✅ Passed The changes update both the download URLs and the autoupdate configuration to use the correct zls--windows pattern as required in issue #2457, directly addressing the resource-not-found error without altering unrelated fields.
Out of Scope Changes Check ✅ Passed All modifications are focused solely on correcting download URLs and autoupdate entries for the zls-dev manifest, with no unrelated code or logic changes introduced.
Description Check ✅ Passed The pull request description follows the repository template by providing a concise summary of changes, a clear “Closes #2457” section, and the required checked boxes confirming use of the conventional title and reading the contributing guide.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d57803 and 2e07d02.

📒 Files selected for processing (1)
  • bucket/zls-dev.json (2 hunks)
🔇 Additional comments (1)
bucket/zls-dev.json (1)

8-17: Double-check SHA-256 hashes now that artifact paths changed: The Windows URLs in bucket/zls-dev.json were updated; download each ZIP (x86_64, x86, aarch64) and verify its SHA-256 matches the corresponding hash entries to avoid shipping a broken Scoop manifest.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

zls-dev

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng merged commit 5620f58 into ScoopInstaller:master Sep 26, 2025
4 checks passed
@z-Fng z-Fng deleted the fix-zls-dev branch September 26, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected]+1840a4b8: download via aria2 failed
1 participant