xournalpp-nightly: Update to the latest version, fix autoupdate & installation, add arm64 version #2451

aliesbelik · 2025-09-05T14:45:29Z

Update to the latest version.
Fix autoupdate & installation.
Add arm64 version.
I have read the Contributing Guide.

Summary by CodeRabbit

New Features
- Added native ARM64 support for nightly Windows builds.
Chores
- Bumped nightly version to 1.2.8-20250926.
- Switched Windows 64-bit package to AMD64 artifact and updated extraction paths.
- Enhanced auto-update to track AMD64 and ARM64 nightly artifacts.
- Removed an unnecessary pre-install step to streamline installation.

…tallation, add arm64 version

coderabbitai · 2025-09-05T14:45:37Z

Walkthrough

Bumps nightly manifest to 1.2.8-20250926, replaces 64-bit x86_64 artifact with AMD64 (adds extract_dir), adds ARM64 architecture with URL/hash/extract_dir, updates autoupdate entries for both architectures, and removes the top-level pre_install block.

Changes

Cohort / File(s)	Summary of edits
Manifest update: version, artifacts, autoupdate `bucket/xournalpp-nightly.json`	Version updated to `1.2.8-20250926`; 64-bit URL switched from x86_64 to AMD64 and hash updated; `architecture.64bit.extract_dir` added; new `architecture.arm64` block added with its `url`, `hash`, and `extract_dir`; removed top-level `pre_install`; `autoupdate` entries updated for AMD64 and added for ARM64 (with `extract_dir` templates).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Updater as App Updater
  participant Manifest as Manifest (`bucket/xournalpp-nightly.json`)
  participant Remote as GitHub Releases

  Note over Updater,Manifest: Determine host architecture
  Updater->>Manifest: Read available architectures (`64bit`, `arm64`)
  alt Host is AMD64
    Updater->>Remote: Download AMD64 zip (URL from manifest)
    Remote-->>Updater: AMD64 zip + checksum
    Updater->>Updater: Verify hash, extract to AMD64 extract_dir
  else Host is ARM64
    Updater->>Remote: Download ARM64 zip (URL from manifest)
    Remote-->>Updater: ARM64 zip + checksum
    Updater->>Updater: Verify hash, extract to ARM64 extract_dir
  end
  Updater->>Updater: Install/update binaries & shortcuts

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop and nibble at the nightly feed,
AMD64 and ARM in a tidy seed,
New version stamped, old pre-install freed,
Hashes checked, extract dirs agreed —
A carrot-coded update, swift as speed 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description lists the change points and confirms reading the contributing guide but does not include the required “Closes #XXXX” or “Relates to #XXXX” section nor the first checklist item for using the conventional PR title as specified in the repository template.	Please add a “Closes #XXXX” or “Relates to #XXXX” line if applicable and include or tick the first checklist item about using the conventional PR title template to fully match the required description structure.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly names the xournalpp-nightly manifest and clearly summarizes the key changes—version bump, autoupdate and installation fixes, and the addition of arm64 support—in a single concise sentence.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 770f629 and c0f1f2f.

📒 Files selected for processing (1)

bucket/xournalpp-nightly.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: WindowsPowerShell

🔇 Additional comments (1)

bucket/xournalpp-nightly.json (1)

8-15: AMD64/ARM64 archives handled correctly

Adding the extract_dir entries for both AMD64 and ARM64 matches the folder names shipped inside the current nightly zip artifacts, so Scoop will now drop the binaries in the expected layout without the old pre_install shim. 👍

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-05T14:46:23Z

All changes look good.

Wait for review from human collaborators.

xournalpp-nightly

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

bucket/xournalpp-nightly.json (2)

33-35: Autoupdate: include hash for unattended bumps.
Add a per-arch hash pointing to the release’s “.zip.sha256” so automated PRs have hashes.

Apply:

                 "url": "https://github.com/xournalpp/xournalpp/releases/download/nightly/xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-AMD64.zip",
-                "extract_dir": "xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-AMD64"
+                "extract_dir": "xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-AMD64",
+                "hash": { "url": "$url.sha256" }

36-38: Autoupdate (ARM64): mirror the hash addition.
Keeps both architectures consistent.

Apply:

                 "url": "https://github.com/xournalpp/xournalpp/releases/download/nightly/xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-ARM64.zip",
-                "extract_dir": "xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-ARM64"
+                "extract_dir": "xournalpp-$matchMain+dev-nightly-$matchDate-windows-portable-ARM64",
+                "hash": { "url": "$url.sha256" }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef8595 and 839bad5.

📒 Files selected for processing (1)

bucket/xournalpp-nightly.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: PowerShell
GitHub Check: WindowsPowerShell

🔇 Additional comments (3)

bucket/xournalpp-nightly.json (3)

2-2: Version bump looks consistent with checkver replace.
1.2.8-20250904 matches ${main}-${date} from the regex groups.

12-15: Add ARM64: good addition.
Path structure aligns with 64-bit; same bin layout expected.

8-11: Manual SHA256 verification required for AMD64 artifact (bucket/xournalpp-nightly.json lines 8–11)
The .zip.sha256 URL returned 404; download the AMD64 ZIP and compute its SHA256 locally to ensure it matches the manifest’s hash. The extract_dir name is correct.

aliesbelik · 2025-09-16T13:15:13Z

/verify

github-actions · 2025-09-16T13:16:09Z

All changes look good.

Wait for review from human collaborators.

xournalpp-nightly

Check the full log for details.

z-Fng · 2025-09-27T13:53:51Z

/verify

github-actions · 2025-09-27T13:54:57Z

All changes look good.

Wait for review from human collaborators.

xournalpp-nightly

Check the full log for details.

z-Fng · 2025-09-27T14:17:48Z

/verify. Keep URL same as in GitHub API to use GitHub predefined hash extraction.

github-actions · 2025-09-27T14:18:46Z

All changes look good.

Wait for review from human collaborators.

xournalpp-nightly

Check the full log for details.

z-Fng

Thanks!

xournalpp-nightly: Update to the latest version, fix autoupdate & ins…

839bad5

…tallation, add arm64 version

github-actions bot added the review-needed label Sep 5, 2025

coderabbitai bot reviewed Sep 5, 2025

View reviewed changes

xournalpp-nightly: Update to version 1.2.8-20250924

770f629

aliesbelik force-pushed the xournalpp-upd branch from 83be3a3 to 770f629 Compare September 24, 2025 16:01

xournalpp-nightly: Update to version 1.2.8-20250926

e82dd9a

se Github predefined hash extraction

c0f1f2f

z-Fng approved these changes Sep 27, 2025

View reviewed changes

z-Fng merged commit b4316cb into ScoopInstaller:master Sep 27, 2025
3 checks passed

aliesbelik deleted the xournalpp-upd branch September 27, 2025 22:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

xournalpp-nightly: Update to the latest version, fix autoupdate & installation, add arm64 version #2451

xournalpp-nightly: Update to the latest version, fix autoupdate & installation, add arm64 version #2451

Uh oh!

aliesbelik commented Sep 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

aliesbelik commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

z-Fng commented Sep 27, 2025

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

z-Fng commented Sep 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

z-Fng left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xournalpp-nightly: Update to the latest version, fix autoupdate & installation, add arm64 version #2451

xournalpp-nightly: Update to the latest version, fix autoupdate & installation, add arm64 version #2451

Uh oh!

Conversation

aliesbelik commented Sep 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Sep 5, 2025

xournalpp-nightly

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

aliesbelik commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

xournalpp-nightly

Uh oh!

z-Fng commented Sep 27, 2025

Uh oh!

github-actions bot commented Sep 27, 2025

xournalpp-nightly

Uh oh!

z-Fng commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2025

xournalpp-nightly

Uh oh!

z-Fng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aliesbelik commented Sep 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 5, 2025 •

edited

Loading

z-Fng commented Sep 27, 2025 •

edited

Loading