everything-alpha: check properly for the existence of the Everything service (fix #2216) #2279
Conversation
|
All changes look good. Wait for review from human collaborators. everything-alpha
|
…service (fix ScoopInstaller#2216) In addition to what is described in the linked issue, it also fixes a few other things: - remove the right service during uninstall by using the service name gotten from PowerShell - stop only the processes linked to that application Those fixes are meant to handle a proper cohabitation of different versions of Everything, no matter how many processes or services they each have.
ymeine
force-pushed
the
issue-2216-everything-alpha-service-check
branch
from
3eaf78b to
6f51e0e
Compare
|
It should align with |
|
@HUMORCE I guess you meant the opposite then, that In that case, do you mean that I should create an equivalent PR for If that is the case, the current PR here would require a proper review and approval first, so that work is not duplicated with the upcoming PR for |
Yes, label alpha-specific code with commented separately as possible, for better maintainability |
In addition to what is described in the linked issue, it also fixes a few other things:
Those fixes are meant to handle a proper cohabitation of different versions of Everything, no matter how many processes or services they each have.
Closes #2216