postgresql: Update manifest #7156

Juemuren · 2025-09-11T18:04:37Z

Make notes neater and clearer
Remove depends , files can now be extracted correctly without 7zip19.00-helper (refer to [email protected]: decompress error #3816)
Fix checkver, add / at its end
Update version to 17.6 manually

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

Summary by CodeRabbit

Bug Fixes
- Fixed 64-bit download URL to ensure reliable retrieval and installation.
- Streamlined extraction by using a dedicated extraction directory for more consistent installs.
Documentation
- Clarified post-install notes with simpler, more direct instructions and improved capitalization.
Chores
- Removed an unneeded helper dependency to reduce setup friction.
- Aligned auto-update URL with the new download format for consistency.

- Make `notes` neater and clearer - Remove `depends` , files can now be extracted correctly without `7zip19.00-helper`

coderabbitai · 2025-09-11T18:04:45Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 2c7b8bb and 55fad28.

📒 Files selected for processing (1)

bucket/postgresql.json (2 hunks)

 ____________________________________________________________________________________________________________________________________________
< Every great developer you know got there by solving problems they were unqualified to solve until they actually did it. - Patrick McKenzie >
 --------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Walkthrough

Updated Scoop manifest for PostgreSQL: removed depends, replaced pre_install with extract_dir="pgsql", simplified notes, and adjusted 64-bit URLs (and autoupdate URLs) to remove URL fragments. Other fields remain unchanged.

Changes

Cohort / File(s)	Summary
Scoop manifest update `bucket/postgresql.json`	Removed `depends`; added `extract_dir: "pgsql"`; deleted `pre_install` block; simplified `notes[0]` and `notes[1]`; updated `architecture.64bit.url` and `autoupdate.architecture.64bit.url` to plain ZIP URLs without URL fragments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws—a tidy hop,
Extracts now zip to “pgsql” stop.
No helper crates, no hash-tag trails,
Clean URLs and simpler tales.
Service starts with gentle cheer—
pg_ctl whispers, crisp and clear.
Carrot commits approved, my dear! 🥕

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting in your project's settings in CodeRabbit to disable the poems in the walkthrough.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "postgresql: Update manifest" is concise, follows the repository's conventional ": " pattern, and accurately describes the primary change (an update to the postgresql manifest). It is short and clear enough for a teammate scanning history to understand the PR's intent without listing implementation details. Therefore it meets the title requirements.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	The PR description provides a clear, concise summary of the primary goals (notes cleanup, removal of depends, checkver fix, and manual version bump) and the repository checklist items are checked, but it does not list some manifest-level changes visible in the diff (removed pre_install block, added extract_dir, and URL fragment cleanup) and it lacks an explicit "Closes/Relates to" line even though it references #3816; overall the description is mostly complete and follows the template structure.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-11T18:05:40Z

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

bucket/postgresql.json (1)
7-8: Notes copy tidy-up looks good; consider being explicit with PGDATA.

To avoid ambiguity if PGDATA isn’t set in a custom shell/session, you could show the explicit flag in the examples.
-        "Run 'pg_ctl start' to start the database and 'pg_ctl stop' to stop it.",
+        "Run 'pg_ctl -D \"%PGDATA%\" start' to start the database and 'pg_ctl -D \"%PGDATA%\" stop' to stop it.",

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d48aaf and 2c7b8bb.

📒 Files selected for processing (1)

bucket/postgresql.json (2 hunks)

🔇 Additional comments (3)

bucket/postgresql.json (3)

13-13: URL fragment removal LGTM; revalidate the hash.

Dropping #/dl.zip_ is correct and should allow Scoop to auto-extract. Since the file bytes are the same, the hash likely remains valid—please recheck locally to be safe.

17-17: Confirm archive layout for extract_dir=pgsql.

This assumes the zip’s top-level directory is consistently pgsql. If EDB ever changes this, installs will fail. Please confirm for 17.4 and spot-check a prior version.

43-43: Autoupdate URL aligned with runtime URL.

Looks correct and consistent with checkver. No further action.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

bucket/postgresql.json (3)
2-2: Consider including the packaging revision in version (to avoid hardcoding “-1” elsewhere).

EDB filenames include a “-” suffix. Keeping "version": "17.6" while hardcoding -1 in URLs risks breakage if a -2 re-spin appears. Easiest alignment: encode the revision in version now.

Apply:
-    "version": "17.6",
+    "version": "17.6-1",
Follow-up: see my suggestions on checkver and autoupdate below to keep things consistent.

36-39: Optional: make checkver selection safer and (if you encode revision in version) format it via replace.

Add "reverse": true to prefer the latest directory if listing order varies.

If you adopt version: "17.6-1", you can stamp -1 via replace for now.
     "checkver": {
         "url": "https://www.postgresql.org/ftp/source/",
-        "regex": "v(?<version>[\\d.]+)/"
+        "regex": "v(?<version>[\\d.]+)/",
+        "reverse": true,
+        "replace": "$version-1"
     },
Note: This still won’t auto-track a future -2 re-spin, but it keeps manifest fields consistent and removes the need to hardcode -1 elsewhere.

43-43: Autoupdate URL: avoid hardcoding “-1” if you move the revision into version.

With version: "17.6-1", let the URL consume $version directly.
-                "url": "https://get.enterprisedb.com/postgresql/postgresql-$version-1-windows-x64-binaries.zip"
+                "url": "https://get.enterprisedb.com/postgresql/postgresql-$version-windows-x64-binaries.zip"
If you keep version: "17.6", current line is fine—just be aware it will miss -2 re-spins.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c7b8bb and 55fad28.

📒 Files selected for processing (1)

bucket/postgresql.json (2 hunks)

🔇 Additional comments (3)

bucket/postgresql.json (3)

7-8: Notes copyedits look good.

Clearer phrasing; matches PGDATA usage set by env.

17-17: extract_dir=“pgsql” is the right simplification; please double-check the top-level folder.

Most EDB binaries zips root under “pgsql/”. The script above also validates this implicitly via pg_ctl.exe presence.

13-14: Verified — SHA256 and ZIP layout OK.

SHA256 matches d378882abd001a186735acd6f6ba716bca6ccd192e800412d4fd15ed25376b3e; archive contains pgsql/ and pgsql/bin/pg_ctl.exe (pgAdmin 4 present).

Juemuren · 2025-09-11T19:42:47Z

/verify

github-actions · 2025-09-11T19:43:48Z

All changes look good.

Wait for review from human collaborators.

postgresql

postgresql: Update manifest

2c7b8bb

- Make `notes` neater and clearer - Remove `depends` , files can now be extracted correctly without `7zip19.00-helper`

github-actions bot added the manifest-fix-needed label Sep 11, 2025

coderabbitai bot reviewed Sep 11, 2025

View reviewed changes

postgresql.json: Update to 17.6 and correct checkvar

55fad28

coderabbitai bot reviewed Sep 11, 2025

View reviewed changes

github-actions bot removed the manifest-fix-needed label Sep 11, 2025

github-actions bot added the review-needed label Sep 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

postgresql: Update manifest #7156

postgresql: Update manifest #7156

Uh oh!

Juemuren commented Sep 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Juemuren commented Sep 11, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

postgresql: Update manifest #7156

Are you sure you want to change the base?

postgresql: Update manifest #7156

Uh oh!

Conversation

Juemuren commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks (3 passed)

Uh oh!

github-actions bot commented Sep 11, 2025

postgresql

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Juemuren commented Sep 11, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

postgresql

Uh oh!

Uh oh!

Juemuren commented Sep 11, 2025 •

edited

Loading

coderabbitai bot commented Sep 11, 2025 •

edited

Loading