claude-code: Add v1.0.108 #7124
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughAdds a new Scoop manifest Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Scoop
participant GCS as "GCS Releases"
participant Manifest as "release manifest.json"
Note over User,Scoop: Install flow
User->>Scoop: scoop install claude-code
Scoop->>GCS: GET /.../win32-x64/claude.exe (v1.0.107)
GCS-->>Scoop: claude.exe (binary)
Scoop->>Scoop: verify sha256, install binary, set CLAUDE_CODE_GIT_BASH_PATH, create shortcut
Note over Scoop,Manifest: Autoupdate checksum retrieval
Scoop->>Manifest: GET /.../manifest.json
Manifest-->>Scoop: { platforms: { "win32-x64": { checksum: "sha256" } } }
Scoop->>Scoop: use checksum to validate autoupdate download
Note over User,Scoop: Uninstall purge
User->>Scoop: scoop uninstall claude-code --purge
Scoop->>Scoop: remove %LOCALAPPDATA%\claude-cli-nodejs and %USERPROFILE%\.claude
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Poem
✨ Finishing Touches🧪 Generate unit tests
Comment |
|
All changes look good. Wait for review from human collaborators. claude-code
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
bucket/claude-code.json (3)
15-20: Avoid creating a shortcut for a CLI toolScoop generally doesn’t add Start Menu shortcuts for console apps. Launching a console exe from a shortcut is noisy and not useful.
- "shortcuts": [ - [ - "claude.exe", - "Claude Code" - ] - ],
4-4: Homepage mismatch with linked issueThe linked issue cites the GitHub repo as homepage. Please confirm whether to use the product page or the repository URL for consistency with bucket conventions.
34-40: Ensure checkver matches binary releases: Verify that NPM’s “latest” version always corresponds to the Windows EXE in your GCS bucket (e.g. 1.0.107 → …/1.0.107/win32-x64/claude.exe) and that the bucket prefix (86c565f3-…) remains stable; if not, switch to a vendor-provided manifest endpoint (GitHub or JSON).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
bucket/claude-code.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/claude-code.json (1)
11-13: Use$env:SCOOPand declare Git as a dependency
Verify in PowerShell that the shim exists:Test-Path "$env:SCOOP\shims\bash.exe"Then update
bucket/claude-code.jsonaccordingly:"env_set": { - "CLAUDE_CODE_GIT_BASH_PATH": "$scoopdir\\shims\\bash.exe" + "CLAUDE_CODE_GIT_BASH_PATH": "$env:SCOOP\\shims\\bash.exe" }, + "depends": ["git"],This ensures Git is installed before referencing its
bash.exe. (gist.github.com, github.com)
|
/verify |
|
All changes look good. Wait for review from human collaborators. claude-code
|
Co-authored-by: HUMORCE <[email protected]>
|
@HUMORCE: I've suggested a way to set |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
bucket/claude-code.json (1)
58-62: .ForEach() is fine in Windows PowerShell 5.1The use here is compatible with Windows PowerShell 5.1+. No change needed.
🧹 Nitpick comments (3)
bucket/claude-code.json (3)
53-63: Purge: swallow IO exceptions to avoid uninstall failuresLocked files or permissions can break uninstall; ignore failures.
Apply:
- " $Directories.ForEach{", - " if ([System.IO.Directory]::Exists($_)) {", - " $null = [System.IO.Directory]::Delete($_,$true)", - " }", - " }", + " $Directories.ForEach{", + " if ([System.IO.Directory]::Exists($_)) {", + " try { [System.IO.Directory]::Delete($_, $true) } catch {}", + " }", + " }",
35-41: CLI apps generally shouldn’t add Start Menu shortcutsScoop convention: omit shortcuts for non-GUI tools.
Apply:
- "shortcuts": [ - [ - "claude.exe", - "Claude Code" - ] - ], +
65-68: Tighten checkver regexAnchor to a semver to avoid accidental matches.
Apply:
- "regex": "(.*)" + "regex": "^\\d+\\.\\d+\\.\\d+$"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/claude-code.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-05T07:52:26.393Z
Learnt from: o-l-a-v
PR: ScoopInstaller/Main#7124
File: bucket/claude-code.json:21-33
Timestamp: 2025-09-05T07:52:26.393Z
Learning: The .ForEach() method is available on arrays and collections in Windows PowerShell 5.1 (and since PowerShell 4.0). These are PowerShell-specific extension methods in System.Management.Automation, not .NET instance methods. Syntax like $array.ForEach{} is valid in Windows PowerShell 5.1.
Applied to files:
bucket/claude-code.json
🔇 Additional comments (1)
bucket/claude-code.json (1)
2-3: Align PR metadata with manifest version and verify checksum
- PR title/description still reference 1.0.107, but
bucket/claude-code.jsonand upstream stable release are at 1.0.108. Update the PR metadata to 1.0.108 (or pin the manifest back to 1.0.107 with matching URL/hash).- Automated script couldn’t compute the SHA256 (no available utility); please manually confirm that the
hashfield (94345a76…731b779) matches the downloaded 1.0.108 binary.
|
/verify |
|
All changes look good. Wait for review from human collaborators. claude-code
|
Closes #7118
Thanks to following Scoop bucket for a lot of it: https://github.com/wilt00/scoop-bucket/blob/main/bucket/claude-code.json.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit