Skip to content

Conversation

junian
Copy link
Contributor

@junian junian commented Sep 1, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated cppcryptfsctl to version 1.4.4.6.
    • Refreshed download links and checksums for both 32‑bit and 64‑bit builds to match the new release.
    • Updated auto-update URL templates to the new release path format.
    • No changes to installation behavior, commands, or configuration — users will receive the updated binaries when installing or updating.

Copy link

coderabbitai bot commented Sep 1, 2025

Walkthrough

Bump cppcryptfsctl manifest version from 1.4.4.5 to 1.4.4.6; update 32-bit and 64-bit release URLs and their SHA-256 hashes; update autoupdate URL templates to include v$version; other manifest fields (bin, homepage, checkver, description) unchanged.

Changes

Cohort / File(s) Summary of changes
Manifest update
bucket/cppcryptfsctl.json
Update version to 1.4.4.6; refresh architecture.64bit.url and architecture.32bit.url to v1.4.4.6 release paths; update corresponding 32-bit and 64-bit SHA-256 hashes; update autoupdate URL templates to use v$version; other top-level fields (bin, homepage, checkver, description) unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through hashes, neat and new,
From .5 to .6 the release flags flew.
URLs dressed with a tiny "v",
Checksums refreshed — neat as can be.
Tail twitch, stamp approved — onward I stew. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7e35433 and fcdc463.

📒 Files selected for processing (1)
  • bucket/cppcryptfsctl.json (2 hunks)
🔇 Additional comments (5)
bucket/cppcryptfsctl.json (5)

2-2: Version bump looks correct.
No schema changes; consistent with autoupdate strategy.


8-9: Release URLs fixed with required ‘v’ prefix.
These should resolve correctly against GitHub releases.


18-19: 32-bit URLs correctly use ‘v’ tag and filename mapping.
The download-to-rename fragments look right.


12-13: [r​un_scripts]

#!/usr/bin/env bash
set -euo pipefail
declare -A files=(
  ["https://github.com/bailey27/cppcryptfs/releases/download/v1.4.4.6/cppcryptfsctl.exe"]="057f7b14aa7db5d9715d15e80ca2f22e9967a210c9a61a2eaa772d50b4963618"
  ["https://github.com/bailey27/cppcryptfs/releases/download/v1.4.4.6/cppcryptfs.exe"]="8453ede076f596c519c2220646db695e77621a09ee312212f9a2481457de81fd"
)
tmp="$(mktemp -d)"; trap 'rm -rf "$tmp"' EXIT
for url in "${!files[@]}"; do
  f="$tmp/$(basename "$url")"
  curl -LsS "$url" -o "$f"
  calc=$(python3 - "$f" <<'EOF'
import hashlib, sys
with open(sys.argv[1], 'rb') as fh:
    print(hashlib.sha256(fh.read()).hexdigest())
EOF
)
  exp="${files[$url]}"
  printf "%s\n  expected: %s\n  actual:   %s\n  %s\n\n" \
    "$url" "$exp" "$calc" "$( [ "$calc" = "$exp" ] && echo OK || echo MISMATCH )"
done

22-23: 32-bit SHA256 hashes verified and match expected values.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Sep 1, 2025

Your changes do not pass checks.

cppcryptfsctl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a777d5 and 7e35433.

📒 Files selected for processing (1)
  • bucket/cppcryptfsctl.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/cppcryptfsctl.json

[error] 1-1: Hashes step failed for cppcryptfsctl.json: 404 Not Found while downloading hash for cppcryptfsctl32.exe.


[error] 1-1: Autoupdate failed: Could not find hash in GitHub releases for cppcryptfsctl (404); hash for cppcryptfsctl32.exe could not be downloaded.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/cppcryptfsctl.json (2)

2-2: Version bump to 1.4.4.6 looks good.


12-14: Recompute hashes after fixing the download URLs
The JSON currently points to …/download/1.4.4.6/…, but the actual release path is …/download/v1.4.4.6/…. Please manually download each 64-bit and 32-bit binary from the corrected URLs and update their SHA256 values in bucket/cppcryptfsctl.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant