Skip to content

Conversation

ESadek-MO
Copy link
Contributor

part of #164

@rcomer
Copy link
Member

rcomer commented Nov 4, 2024

Do we know why repo review advises the code to be under src? A quick check of the big four scientific python packages show three of them (numpy, pandas, scipy) have their package at the top of the repo like tephi currently does. matplotlib has its C and C++ code under src but its python code under lib.

@ESadek-MO
Copy link
Contributor Author

It's not repo review that's asking for this, so much as following Iris' conventions as far as I know! Repo review wants tests to be in root, but the rest of it is just standardising. If this proves too difficult, I don't mind putting this on the backburner.

@bjlittle
Copy link
Member

bjlittle commented Nov 5, 2024

@rcomer See https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ for some pros and cons

Personally I prefer the src-layout, but that's just me 😉

@trexfeathers trexfeathers marked this pull request as draft April 9, 2025 09:58
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Aug 20, 2025
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 24, 2025
Copy link

In order to maintain a backlog of relevant PRs, we automatically label them as stale after 168 days of inactivity.
If this PR is still important to you, then please comment on this PR and the stale label will be removed.
Otherwise this PR will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue or pull request label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale A stale issue or pull request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants