Skip to content

Make ODEProblem into a mutable struct, v2 #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Make ODEProblem into a mutable struct, v2 #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb384b3
Make ODEProblem into a mutable struct
wsmoses Sep 13, 2023
97517dd
add a big warning on mutation of ODEProblem
ChrisRackauckas Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/problems/ode_problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ prob = ODEProblemLibrary.prob_ode_linear
sol = solve(prob)
```
"""
struct ODEProblem{uType, tType, isinplace, P, F, K, PT} <:
mutable struct ODEProblem{uType, tType, isinplace, P, F, K, PT} <:
AbstractODEProblem{uType, tType, isinplace}
"""The ODE is `du = f(u,p,t)` for out-of-place and f(du,u,p,t) for in-place."""
f::F
Expand Down Expand Up @@ -162,6 +162,16 @@ struct ODEProblem{uType, tType, isinplace, P, F, K, PT} <:
end
TruncatedStacktraces.@truncate_stacktrace ODEProblem 3 1 2

function Base.setproperty!(prob::ODEProblem, s::Symbol, v)
@warn "Mutation of ODEProblem detected. SciMLBase v2.0 has made ODEProblem temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and ODEProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v)
end

function Base.setproperty!(prob::ODEProblem, s::Symbol, v, order::Symbol)
@warn "Mutation of ODEProblem detected. SciMLBase v2.0 has made ODEProblem temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and ODEProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v, order)
end

"""
ODEProblem(f::ODEFunction,u0,tspan,p=NullParameters(),callback=CallbackSet())

Expand Down