Skip to content

fix: Camera.viewToRay end position calculation #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Camera.viewToRay end position calculation #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sceneview/src/main/java/io/github/sceneview/utils/Camera.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,11 @@ fun Camera.worldToView(worldPosition: Position): Float2 =
* x = (0 = left, 0.5 = center, 1 = right)
* y = (0 = bottom, 0.5 = center, 1 = top)
*
* @return A Ray from the camera near to far / infinity
* @return A Ray from the camera near to far
*/
fun Camera.viewToRay(viewPosition: Float2): Ray {
val startPosition = viewToWorld(viewPosition, z = 0.0f)
val endPosition = viewToWorld(viewPosition, z = 1.0f)
val endPosition = viewToWorld(viewPosition, z = 0.99f)
val direction = endPosition - startPosition
return Ray(origin = startPosition, direction = direction)
}