Skip to content

Removed flatbuffers and code related to loading models in Sceneform format #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Removed flatbuffers and code related to loading models in Sceneform format #477

merged 1 commit into from
May 13, 2024

Conversation

grassydragon
Copy link
Contributor

Closes #172

ThomasGorisse
ThomasGorisse approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@ThomasGorisse ThomasGorisse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!
Weren't there anything still depending on it from both sceneview and arsceneview?
Even the old bringed back ViewNode?
I was convinced it was still generating a runtime exception with some samples but, if it's not the case, that's perfect!!!

@grassydragon
Copy link
Contributor Author

I've only tested the model-viewer and ar-model-viewer samples so I should also check if the ViewNode still works. As far as I know there aren't any dependencies on the removed code.

@ThomasGorisse
Copy link
Contributor

ThomasGorisse commented May 12, 2024 •
edited
Loading

If you don't mind confirming the old ViewNode (not ViewNode2) is still working, that would be perfect.

@ThomasGorisse
Copy link
Contributor

ThomasGorisse commented May 13, 2024 •
edited
Loading

I also made the check on my side with a bunch of Nodes including the ViewNode and confirm everything is working fine.
Thanks for making it @grassydragon

@ThomasGorisse ThomasGorisse merged commit eecfe8e into main May 13, 2024
@grassydragon
Copy link
Contributor Author

Thank you! I didn't find the time to test it yesterday 😅

@grassydragon grassydragon deleted the feature/remove-flatbuffers branch May 13, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasGorisse ThomasGorisse ThomasGorisse approved these changes

@RGregat RGregat Awaiting requested review from RGregat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate class error when using TensorFlow-lite together
2 participants
@grassydragon @ThomasGorisse