Hotfix for Release 2.0.4 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antiglobalist
commented
Mar 7, 2024
|
|
||
| override fun destroy() { | ||
| if (!isDestroyed) { | ||
| destroyARCore() |
There was a problem hiding this comment.
You use LifeCycleObserver as the main place to call ArCore lifecycle functions
And you don't need to call it here again
I didn't find any side cases
Antiglobalist
commented
Mar 7, 2024
| } | ||
|
|
||
| fun destroyARCore() { | ||
| val scope = lifecycle?.coroutineScope ?: CoroutineScope(Dispatchers.IO) |
There was a problem hiding this comment.
As I wrote in issue - Coroutines is not fit tool to execute background operation a specialty on Destroy callback
Antiglobalist
commented
Mar 7, 2024
| super.destroy() | ||
| } | ||
|
|
||
| fun destroyARCore() { |
There was a problem hiding this comment.
It is no reasons to place public function cuz it's internal behavior
Same as all others lifecycle calls
|
looks good to me |
ThomasGorisse
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion - #435
Issues:
The second call of destroy() was removed to prevent crash
Coroutines were replaced to ExecutorService