Skip to content

call arcore.destroy off of main thread Fixes #407 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

call arcore.destroy off of main thread Fixes #407 #408

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e318bbc
call arcore.destroy off of main thread
Feb 5, 2024
7b3e6a6
rename method as per PR comment
Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions arsceneview/src/main/java/io/github/sceneview/ar/ARSceneView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.activity.ComponentActivity
import androidx.lifecycle.DefaultLifecycleObserver
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.coroutineScope
import com.google.android.filament.Engine
import com.google.android.filament.IndirectLight
import com.google.android.filament.MaterialInstance
Expand Down Expand Up @@ -44,6 +45,9 @@ import io.github.sceneview.model.Model
import io.github.sceneview.model.ModelInstance
import io.github.sceneview.node.LightNode
import io.github.sceneview.node.Node
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch

/**
* A SurfaceView that integrates with ARCore and renders a scene
Expand Down Expand Up @@ -561,7 +565,7 @@ open class ARSceneView @JvmOverloads constructor(

override fun destroy() {
if (!isDestroyed) {
arCore.destroy()
destroyAr()

defaultCameraNode?.destroy()
defaultCameraStream?.destroy()
Expand All @@ -573,6 +577,14 @@ open class ARSceneView @JvmOverloads constructor(
super.destroy()
}

fun destroyAr() {
val scope = lifecycle?.coroutineScope ?: CoroutineScope(Dispatchers.IO)
scope.launch(Dispatchers.IO) {
// destroy should be called off the main thread since it hangs for many seconds
arCore.destroy()
}
}

class DefaultARCameraNode(engine: Engine) : ARCameraNode(engine) {
init {
// Set the exposure on the camera, this exposure follows the sunny f/16 rule
Expand All @@ -596,7 +608,7 @@ open class ARSceneView @JvmOverloads constructor(
}

override fun onDestroy(owner: LifecycleOwner) {
arCore.destroy()
destroyAr()
}
}

Expand Down