Skip to content

Conversation

JakeWharton
Copy link
Contributor

No description provided.

@JakeWharton JakeWharton changed the title Migrate Disposables static factories to Disposable interface 3.x: Migrate Disposables static factories to Disposable interface Dec 19, 2019
@akarnokd akarnokd added 3.x Cleanup Java 8 Issues and PRs related to Java 8 support labels Dec 19, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 19, 2019
* executed exactly once when the {@code Disposable} is disposed.
* @param run the Runnable to wrap
* @return the new Disposable instance
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these additions would count as @since 3.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Done.

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #6781 into 3.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6781      +/-   ##
============================================
+ Coverage     98.21%   98.26%   +0.04%     
+ Complexity     6257     6256       -1     
============================================
  Files           690      690              
  Lines         45220    45218       -2     
  Branches       6220     6220              
============================================
+ Hits          44414    44434      +20     
+ Misses          283      268      -15     
+ Partials        523      516       -7
Impacted Files Coverage Δ Complexity Δ
...main/java/io/reactivex/rxjava3/core/Scheduler.java 100% <ø> (ø) 11 <0> (ø) ⬇️
...ava3/internal/operators/maybe/MaybeFromFuture.java 100% <100%> (ø) 8 <7> (ø) ⬇️
...a3/internal/operators/maybe/MaybeFromCallable.java 95% <100%> (ø) 6 <4> (ø) ⬇️
.../rxjava3/internal/operators/single/SingleJust.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...io/reactivex/rxjava3/schedulers/TestScheduler.java 100% <100%> (ø) 11 <0> (ø) ⬇️
...a3/internal/operators/maybe/MaybeFromSupplier.java 85% <100%> (ø) 5 <3> (ø) ⬇️
...eactivex/rxjava3/disposables/SerialDisposable.java 100% <100%> (ø) 8 <0> (ø) ⬇️
...operators/completable/CompletableFromSupplier.java 100% <100%> (ø) 4 <3> (ø) ⬇️
...l/operators/completable/CompletableFromAction.java 100% <100%> (ø) 4 <3> (ø) ⬇️
.../internal/operators/single/SingleFromSupplier.java 100% <100%> (ø) 5 <4> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a249f4f...e8f8ee9. Read the comment docs.

@akarnokd akarnokd merged commit 166c529 into ReactiveX:3.x Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Cleanup Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants