Skip to content

Conversation

denobun
Copy link

@denobun denobun commented Sep 28, 2025

What is it?

  • Bug

Description

There is a flaw in the type of RouteLocation['params']
The property values are currently typed as string, but they can be undefined at runtime when a path parameter not present in the URL.

Example demonstrating the issue:
const chatId = useLocation().params.id
console.log('full path:', useLocation().url.href)
console.log('chatId:', chatId)
console.log('typeof chatId:', typeof chatId)

Log 1:
full path: http://localhost/chats/
chatId: undefined
typeof chatId: undefined

Log 2:
full path: http://localhost/chats/1/
chatId: 1
typeof chatId: string

The type definition has been updated to correctly reflect this runtime behavior.
Before: readonly params: Readonly<Record<string, string>>
After: readonly params: Readonly<Record<string, string | undefined>>

@denobun denobun requested a review from a team as a code owner September 28, 2025 13:40
Copy link

changeset-bot bot commented Sep 28, 2025

⚠️ No Changeset found

Latest commit: ed2c161

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants