Revert "Bail if building with Py3" #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would suggest to revert the change that prevents from building an
sdistunder Python 3.I've followed the #398 and #399 issues, and both were addressed by PR #400
The only compatibility issue was for wheels built under Python 3 (with
python setup.py bdist_wheel) and then used under Python 2, and that was only because wheels where considered universal, while they aren't, and that's now addressed by PR #400.Building an
sdist(.tar.gz/.zipformat) and using it across Python 2/3 isn't an issue, as thesetup.pyfile will be executed in each instance and will install only the right parts. Thus, runningpython setup.py sdiston python 3 is entirely valid, and preventing it will cause issue for users.I suggest to revert it before releasing v0.17.1.