Python 3.14 compatibility fixes #1288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now been removed in Python 3.14. Remove obsolete ast types that are supplanted by ast.Constant.
|
Fixes #1287 |
|
This seems to meaningfully change the results of some scans. Can you please look at the test failures? I don't have sufficient time to dig into them myself but maybe @ericwb does |
Comment on lines
-208
to
-210
| elif isinstance(literal, ast.Ellipsis): | ||
| # what do we want to do with this? | ||
| literal_value = None |
There was a problem hiding this comment.
Is this necessary to remove?
There was a problem hiding this comment.
% uvx python3.14 -c"import ast ; ast.Ellipsis"
Traceback (most recent call last):
File "<string>", line 1, in <module>
import ast ; ast.Ellipsis
^^^^^^^^^^^^
AttributeError: module 'ast' has no attribute 'Ellipsis'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use node.value, not node.s which has was previously deprecated but has now been removed in Python 3.14.
Remove obsolete AST types that are supplanted by
ast.Constant.