Fix Test-Connection test to use same API to resolve DNS as cmdlet making it more reliable #8003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
approved these changes
Oct 11, 2018
TravisEz13
approved these changes
Oct 11, 2018
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 7, 2018
…s Windows (PowerShell#8003) Change API to match cmdlet which is more reliable in AzDevOpsPipelines Windows (PowerShell#8003) # Conflicts: # test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In AzDevOps Pipelines on Windows images, they have some sort of protection in place so that a reverse lookup returns the wrong name from a cache. Fix is to use the same API used in the cmdlet to resolve DNS.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests