Replace debugDoingBuild flag with SchedulerPhase #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Could explain for with these phases? |
|
In release mode, if the showToast method is used in initState, then calling the showToast method later will no longer be able to display the toast. |
|
For the specific definition of schedulerPhase, check https://api.flutter.dev/flutter/scheduler/SchedulerPhase.html |
|
You'll need to modify CHANGELOG and pubspec too. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace context.debugDoingBuild flag with SchedulerBinding.instance.schedulerPhase. 'debugDoingBuild' is only valid in debug mode and it should not be used in release mode, 'SchedulerBinding.instance.schedulerPhase' can be used instead.