No Longer prepend uri with slash if it is a query string #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
added
bug
Fixes OpenFeign#887 Changes to target and uri parsing did not take into account Empty Targets or URI provided methods. In these scenarios, the target contains the entire path and the uri will be the query string only. This change takes that into account and no longer prepends a slash in these cases.
kdavisk6
force-pushed
the
gh-887-slash-on-path
branch
from
4545070 to
9c1ae66
Compare
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* No Longer prepend uri with slash if it is a query string Fixes #887 Changes to target and uri parsing did not take into account Empty Targets or URI provided methods. In these scenarios, the target contains the entire path and the uri will be the query string only. This change takes that into account and no longer prepends a slash in these cases. * Removed unnecessary import for Spring from Target Test
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* No Longer prepend uri with slash if it is a query string Fixes #887 Changes to target and uri parsing did not take into account Empty Targets or URI provided methods. In these scenarios, the target contains the entire path and the uri will be the query string only. This change takes that into account and no longer prepends a slash in these cases. * Removed unnecessary import for Spring from Target Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
Changes to target and uri parsing did not take into account
Empty Targets or URI provided methods. In these scenarios,
the target contains the entire path and the uri will be the
query string only. This change takes that into account and
no longer prepends a slash in these cases.