Skip to content

Conversation

eddumelendez
Copy link

See gh-817

@velo
Copy link
Member

velo commented Nov 4, 2018

Hi @eddu, I noticed a few modules are missing.

Any idea how we could check if the book is complete?

@eddumelendez
Copy link
Author

Hi @velo according to the list of modules in the project there is no missing modules in the bom except for example-github, example-wikipedia, benchmark

<module>core</module>
<module>gson</module>
<module>httpclient</module>
<module>hystrix</module>
<module>jackson</module>
<module>jackson-jaxb</module>
<module>jaxb</module>
<module>jaxrs</module>
<module>jaxrs2</module>
<module>okhttp</module>
<module>ribbon</module>
<module>sax</module>
<module>slf4j</module>
<module>reactive</module>
<module>example-github</module>
<module>example-wikipedia</module>
<!-- remove after feign 10.0 release -->
<module>java8</module>
<module>mock</module>
<module>benchmark</module>

Can you point to the modules I am missing?

@velo
Copy link
Member

velo commented Nov 4, 2018

java11 is missing.
There is a new module under review that will become a miss if we don't have a process in place to catch it.

Any suggestions?

@eddumelendez
Copy link
Author

I guess java11 will be released always with the rest of the modules right? if that the case I can add the module to the bom.

There is a new module under review that will become a miss if we don't have a process in place to catch it.

I think we should track it into the issues section. I do not know to avoid missing a module into the bom.

@velo
Copy link
Member

velo commented Nov 7, 2018

I think a simple junit test (on core) that reads both pom files and check if they match, would be good enough.

What do you think?

@velo velo added enhancement For recommending new capabilities waiting for feedback Issues waiting for a response from either to the author or other maintainers waiting for votes Enhancements or changes proposed that need more support before consideration labels Nov 7, 2018
@eddumelendez
Copy link
Author

parent bom could have more modules than dependencies declared into the bom file so they will always match at least we will declare in the test all the modules that should be present. I am not sure about that approach.

@velo
Copy link
Member

velo commented Nov 8, 2018

Well, we can have a exclusion list.... for instance for example-github, example-wikipedia, benchmark.... my main concern is new modules being created, specially by contributors and not making into the bom file.

@velo
Copy link
Member

velo commented Nov 25, 2018

Defer in favor of #846

@velo velo closed this Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For recommending new capabilities waiting for feedback Issues waiting for a response from either to the author or other maintainers waiting for votes Enhancements or changes proposed that need more support before consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants