support charset when build Reader for Response.Body #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 10, 2018 13:42
velo
reviewed
Aug 13, 2018
| */ | ||
| public final class Response implements Closeable { | ||
|
|
||
| private final int status; |
There was a problem hiding this comment.
could you revert this format changes?
runninng mvn clean install should fix code format
velo
added
enhancement
velo
requested changes
Aug 13, 2018
Closed
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* add charset to Response.Body when create Reader * format * support charset when build Reader for Response.Body * support charset when build Reader for Response.Body * support charset when build Reader for Response.Body * format header * format Response
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* add charset to Response.Body when create Reader * format * support charset when build Reader for Response.Body * support charset when build Reader for Response.Body * support charset when build Reader for Response.Body * format header * format Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue#757
We need a asReader(Charset charset) method in Response.Body