Skip to content

Conversation

hosuaby
Copy link
Contributor

@hosuaby hosuaby commented Nov 2, 2024

@xxlabaza this PR is for you.

Tests from the project feign-form write logs in the files in the root directory of the same project. This makes subsequent builds fail. I moved those logs in the temporary folder created by JUnit Jupiter. Check and tell me what you think.

Alternatively, I can move logs produced by tests into target folder.

Test were creating logs files on the root of project, making all subsequent
builds fail.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • annotation-error-decoder/pom.xml
    • lines 49-48
  • apt-test-generator/pom.xml
    • lines 62-61
  • benchmark/pom.xml
    • lines 70-69
  • core/pom.xml
    • lines 37-36
  • core/src/test/java/feign/stream/StreamDecoderTest.java
    • lines 60-70
  • feign-form-spring/src/test/java/feign/form/feign/spring/DownloadClient.java
    • lines 49-51
  • feign-form-spring/src/test/java/feign/form/feign/spring/Dto.java
    • lines 20-19
    • lines 33-32
  • feign-form-spring/src/test/java/feign/form/feign/spring/Server.java
    • lines 113-119
  • feign-form-spring/src/test/java/feign/form/feign/spring/SpringFormEncoderTest.java
    • lines 47-49
    • lines 57-59
    • lines 67-70
    • lines 79-85
  • feign-form-spring/src/test/java/feign/form/feign/spring/converter/SpringManyMultipartFilesReaderTest.java
    • lines 41-42
    • lines 61-80
  • feign-form/src/test/java/feign/form/BasicClientTest.java
    • lines 72-72
    • lines 81-81
    • lines 105-106
    • lines 121-122
    • lines 139-139
    • lines 151-151
  • feign-form/src/test/java/feign/form/Dto.java
    • lines 20-19
    • lines 32-31
  • googlehttpclient/pom.xml
    • lines 54-53
  • gson/src/test/java/feign/gson/GsonCodecTest.java
    • lines 53-56
    • lines 90-97
    • lines 168-177
    • lines 236-245
  • hc5/pom.xml
    • lines 67-66
  • httpclient/pom.xml
    • lines 75-74
  • hystrix/pom.xml
    • lines 78-77
  • jackson-jaxb/pom.xml
    • lines 82-83
  • java11/pom.xml
    • lines 50-49
  • jaxb-jakarta/pom.xml
    • lines 34-35
    • lines 55-57
  • jaxb/pom.xml
    • lines 45-49
  • jaxrs2/pom.xml
    • lines 103-102
  • jaxrs3/pom.xml
    • lines 89-88
  • jaxrs4/pom.xml
    • lines 83-82
  • kotlin/pom.xml
    • lines 71-70
  • moshi/src/test/java/feign/moshi/MoshiDecoderTest.java
    • lines 72-81
  • moshi/src/test/java/feign/moshi/MoshiEncoderTest.java
    • lines 43-45
    • lines 61-67
    • lines 85-94
  • moshi/src/test/java/feign/moshi/Zone.java
    • lines 18-17
    • lines 37-36
  • okhttp/pom.xml
    • lines 59-58
  • pom.xml
    • lines 573-574
  • reactive/pom.xml
    • lines 98-97
  • ribbon/pom.xml
    • lines 83-82
  • soap-jakarta/pom.xml
    • lines 34-35
    • lines 63-62
    • lines 79-81
  • soap/pom.xml
    • lines 55-60
    • lines 70-71

Comment on lines 30 to 31
import java.nio.file.Path;
import java.nio.file.Paths;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.Path;

@velo velo enabled auto-merge (squash) November 4, 2024 00:49
@velo velo merged commit 96a5d70 into OpenFeign:master Nov 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants