Skip to content

Fix expression pattern compilation on android #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Fix expression pattern compilation on android #2136

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
750e90e
Fix expression pattern compilation on android
iProdigy Jul 25, 2023
6377bbe
Add test cases
iProdigy Jul 26, 2023
e2e6efe
Add license header
iProdigy Jul 26, 2023
563986b
Reformat
iProdigy Jul 26, 2023
b16edfd
Merge branch 'master' into patch-1
iProdigy Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/feign/template/Expressions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public final class Expressions {
* <a href="https://www.rfc-editor.org/rfc/rfc6570#section-2.2>RFC 6570 Expressions</a>
*/
private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("^(\\{([+#./;?&=,!@|]?)(.+)})$");
Pattern.compile("^(\\{([+#./;?&=,!@|]?)(.+)\\})$");

// Partially From:
// https://stackoverflow.com/questions/29494608/regex-for-uri-templates-rfc-6570-wanted -- I
Expand Down