Clarify availability of a Response Body in FeignException #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#920 FeignException may contain the data from the response if the response is available and contains data. However, the method `content` is ambiguious and does not reveal it's intent. User's have expressed confusion as to if it is for the Request or the Response. This change adds a new method `responseBody` to addresse this. Use of content is now `@deprecated`.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fixes #920 FeignException may contain the data from the response if the response is available and contains data. However, the method `content` is ambiguious and does not reveal it's intent. User's have expressed confusion as to if it is for the Request or the Response. This change adds a new method `responseBody` to addresse this. Use of content is now `@deprecated`.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fixes #920 FeignException may contain the data from the response if the response is available and contains data. However, the method `content` is ambiguious and does not reveal it's intent. User's have expressed confusion as to if it is for the Request or the Response. This change adds a new method `responseBody` to addresse this. Use of content is now `@deprecated`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920
FeignException may contain the data from the response if the response is available and contains data. However, the method
contentis ambiguous and does not reveal its intent. User's have expressed confusion as to if it is for the Request or the Response.This change adds a new method
responseBodyto addresses this. Use of content is now@deprecated.