Fixes 1003: Do not wrap exceptions in RuntimeException #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimY4
commented
Jul 8, 2019
reactive/src/test/java/feign/reactive/ReactiveInvocationHandlerTest.java
Show resolved
Hide resolved
|
Thanks for this PR. I will review and provide feedback later today. |
kdavisk6
added
the
ready to merge
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003
Initially, the ReactiveInvocationHandler.java was wrapping method invocation in a Callable. That has a few drawbacks, one of which is the fact that we cannot propagate Throwable property and we need to wrap it in some new Exception class.
This PR wraps methodInvocation in a generic Publisher instead. Publisher allows us to signal Throwables back as an error signal and without additional wrapping.