Store::registerDrvOutput make pure virtual
#14127
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be the responsibility of implementations that don't implement it to say so. See also PR NixOS#9799, and issue NixOS#5729
github-actions
bot
added
the
store
Ericson2314
commented
Sep 30, 2025
Comment on lines
+261
to
+264
| void registerDrvOutput(const Realisation & output) override | ||
| { | ||
| unsupported("registerDrvOutput"); | ||
| } |
There was a problem hiding this comment.
#14097 will implement this for the dummy store, but that one is not ready as I am debugging an address sanitizer failure related to C++ header nonsense (one definition rule)
Mic92
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It should be the responsibility of implementations that don't implement it to say so.
Context
See also PR #9799, and issue #5729
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.