Create test for Issue 13247 #14084
Open
Create test for Issue 13247 #14084
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
2 tasks
|
Oh yikes, platform-specific failure? |
…tput In the case where the store object doesn't exist, we do correctly move (rather than copy) the scratch data into place. In this case, the destination store object already exists, but we still want to clean up after ourselves.
Ericson2314
force-pushed
the
issue-13247-test
branch
from
a515cdb to
1074a2e
Compare
Ericson2314
commented
Sep 27, 2025
| delete | ||
|
|
||
| buildViaSubstitute () { | ||
| nix build -f issue-13247.nix "$1" --no-link --max-jobs 0 --substituters "$cache" --no-require-sigs --offline --substitute |
There was a problem hiding this comment.
I had to add --substitute to not make the lack of network access disable substituters. (I added --offline too simply to reproduce the issue in dev builds.)
I am curious why the other substitution tests are not affected by this.
Also, no network should not disable substitutes that don't use the network!
This test ends up being skipped, since the bug has not yet been fixed. A future commit will fix the bug. Progress on NixOS#13247, naturally.
Ericson2314
force-pushed
the
issue-13247-test
branch
from
1074a2e to
e35abb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test ends up being skipped, since the bug has not yet been fixed. A
future commit will fix the bug.
Previous commit fixes a different bug (failure to clean up) that was getting in the way of my test! :)
Context
Progress on #13247, naturally.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.