libstore-c: add nix_store_get_fs_closure #14025
Conversation
RossComputerGuy
force-pushed
the
upstream-RossComputerGuy/feat/expose-computefsclosure
branch
2 times, most recently
from
3267618 to
9237e52
Compare
| * @param[out] context Optional, stores error information | ||
| * @param[in] store nix store reference | ||
| * @param[in] store_path The path to compute from | ||
| * @param[in] flip_direction |
There was a problem hiding this comment.
@roberth is the right thing to just copy the doc from the C++ function?
There was a problem hiding this comment.
If the docs are good, then that's fine
| * @param[in] callback The function to call for every store path | ||
| * @param[in] userdata The userdata to pass to the callback | ||
| */ | ||
| nix_err nix_store_get_fs_closure( |
There was a problem hiding this comment.
I think it would be better to put this above nix_store_realise
|
I assigned to @roberth as he is defacto code owner of this. |
RossComputerGuy
force-pushed
the
upstream-RossComputerGuy/feat/expose-computefsclosure
branch
from
9237e52 to
d93cd0a
Compare
src/libstore-c/nix_api_store.h
Outdated
| * @param[in] flip_direction | ||
| * @param[in] include_outputs | ||
| * @param[in] include_derivers | ||
| * @param[in] callback The function to call for every store path |
There was a problem hiding this comment.
Let's afford the impl some more freedom
| * @param[in] callback The function to call for every store path | |
| * @param[in] callback The function to call for every store path, in no particular order |
RossComputerGuy
force-pushed
the
upstream-RossComputerGuy/feat/expose-computefsclosure
branch
from
d93cd0a to
1f8a5cc
Compare
|
Oh and actually I would like to not expose flip direction, as many stores don't support the reverse direction. (I had an old blocked store API PR fo this, it would be nice to not repeat the same IMO mistake in the C API.) |
Should the C++ API reflect that? Imo, I prefer having feature parity to the C++ API as close as C can get. |
|
Is it feasible to create a small store path graph using the store operations at this point? |
I think we're close to making that possible, I'm not sure what else is needed but I think it may be possible. |
Motivation
Adds a way to call the store API's
computeFSClosurefunction from C.Context
I'd like to be able to call this from the nixops4 Rust bindings.
Upstreams DeterminateSystems#209
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.