Skip to content

Fix update to AR reflection keys being strings not symbols #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix update to AR reflection keys being strings not symbols #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9eed2
Fix update to AR reflection keys being strings not symbols
tatecarr Aug 7, 2016
a395662
RecordSync add reflection keys as string support
tatecarr Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/netsuite_rails/record_sync.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def netsuite_extract_from_record(netsuite_record)
end

if association_keys.include?(local_field)
field_value = reflection_attributes[local_field].
field_value = reflection_attributes[reflection_attributes.keys.first.class == String ? local_field.to_s : local_field].
klass.
where(netsuite_id: field_value.internal_id).
first_or_initialize
Expand Down
2 changes: 1 addition & 1 deletion lib/netsuite_rails/record_sync/push_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def build_netsuite_record(local_record, opts = {})

# TODO pretty sure this will break if we are dealing with has_many

netsuite_field_value = if reflections.has_key?(local_field)
netsuite_field_value = if reflections.has_key?(reflections.keys.first.class == String ? local_field.to_s : local_field)
if (remote_internal_id = local_record.send(local_field).try(:netsuite_id)).present?
{ internal_id: remote_internal_id }
else
Expand Down