fix(android): Canvas was getting blank because of unexpected flush calls #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that current flag for
TNSCanvasinvalidation state was not covering all cases.In particular, state was changed asynchronously due to
GLThreadandChoreographerbeing like 2 tasks running in parallel.This caused multiple issues that resulted in more
flushcalls than expected or none at all, and this whole problem turned canvas blank as mentioned in #84 .I updated old
TNSCanvasproperty to use bitwise flags instead of enums to avoid doing multiple checks and support more things in the future.This seems to completely fix the problem I mentioned.
Fixes #84