cmake: fix templating of SM architecture #4434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeoZDong @yuanyao-nv would either of you have the chance to review this? |
Shadows-of-Fire
approved these changes
May 2, 2025
LeoZDong
approved these changes
May 2, 2025
There was a problem hiding this comment.
Thanks! Make sure you update your commit to contain the sign-off information: https://github.com/NVIDIA/TensorRT/pull/4434/checks?check_run_id=41564787377
Signed-off-by: Connor Baker <[email protected]>
ConnorBaker
force-pushed
the
fix/cmake-sm-architecture-templating
branch
from
26b433f to
901f149
Compare
james-p-xu
pushed a commit
to james-p-xu/TensorRT
that referenced
this pull request
May 17, 2025
Signed-off-by: Connor Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without interpolation, CMake appends the string literal
SMto the list.