Skip to content

Conversation

SnaveSutit
Copy link

Makes highlighting more consistent for NBT paths and other similar syntax.

Before
image

After
image

Allowing underscores doesn't turn all NBT paths with an underscore into an unquoted string.
@rx-dev
Copy link
Collaborator

rx-dev commented Oct 14, 2025

looks like a good change, but it does affect other things. i'll need to look thru the test cases (or can u share some pics of some of them?)

@SnaveSutit
Copy link
Author

SnaveSutit commented Oct 14, 2025

From my examination of the test cases nothing else was effected.

I don't want to spend the time to go through every single test file and take a screenshot, I think it would be more efficient for you to go through them with your expert eye later, since you'll catch any issues quicker and more accurately that way.

@rx-dev
Copy link
Collaborator

rx-dev commented Oct 14, 2025

From my examination of the test cases nothing else was effected.

I don't want to spend the time to go through every single test file and take a screenshot, I think it would be more efficient for you to go through them with your expert eye later, since you'll catch any issues quicker and more accurately that way.

i'll do that later, but it's mostly the one basic test file that goes thru most of the commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants