Skip to content

EventPhases: Fix reference to "addEventListener" #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EventPhases: Fix reference to "addEventListener" #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions EventPhases/explainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ foo.addEventListener(
Syntax of the scheduling integration is TBD (e.g., should there be explicit `scheduler.postForRead()` and `scheduler.postForWrite()` API instead?). We could also imagine the event carrying scheduling methods for brevity:

```js
foo.when("click",
foo.addEventListener("click",
(evt) => {
// ...
evt.on("write", () => { /* ... */ });
Expand Down Expand Up @@ -510,4 +510,4 @@ Many projects have influenced the thinking in this proposal, including:

- [fastdom](https://github.com/wilsonpage/fastdom): Wilson Page's excellent batching approach with optional development-time enforcement (via "strict mode")
- The Minecraft Scripting API's [Before Events](https://learn.microsoft.com/en-us/minecraft/creator/scriptapi/minecraft/server/systembeforeevents?view=minecraft-bedrock-experimental) and [After Events](https://learn.microsoft.com/en-us/minecraft/creator/scriptapi/minecraft/server/systemafterevents?view=minecraft-bedrock-experimental) which cleanly separate a read-only phase from the writable phase of extension execution.
- [The original DART DOM (via the `dart:html` package)](https://rm-dart.web.app/tutorials/web/low-level-html/add-elements), designed by Dart team members, as well as [Erik Arvidsson](https://www.linkedin.com/in/erik-arvidsson-88213a1/) and [the author of this proposal](https://infrequently.org/about-me/). Many solutions to the read/write phasing problem were considered as part of this effort.
- [The original DART DOM (via the `dart:html` package)](https://rm-dart.web.app/tutorials/web/low-level-html/add-elements), designed by Dart team members, as well as [Erik Arvidsson](https://www.linkedin.com/in/erik-arvidsson-88213a1/) and [the author of this proposal](https://infrequently.org/about-me/). Many solutions to the read/write phasing problem were considered as part of this effort.