Add support for concurrent image decode using createImageBitmap. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent image decoding can be implemented in various ways. The simplest way would be to add
img.decoding = "async"to the image element. This works just fine, but it appears the recommended approach is to use thecreateImageBimapAPI. This appears to be slightly faster, but doesn't handle SVG files.To handle this I detect SVG urls and use the async Image element code path for SVG files, and the
createImageBitmapcode path otherwise.Also, the documentation claimed that the input to encodeTexture could be HTMLCanvasElement, Blob or ArrayBuffer. This is not correct anymore, as we requires the existence of width and height attributes. HTMLCanvasElement could work with minor changes, but that needs to be tested, so for now I've corrected the documentation.