❌ Get rid of .expo.js extension, no longer supported in Expo SDK 41+ #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SDK 41 we are removing the .expo.js extension! We have sent PRs to other repos like async-storage and react-native-screens to resolve this, but I only just remembered that we're depending on it here as well. And so this PR was born.
The changes here are backwards compatible, so it doesn't hurt if someone on Expo SDK 39 or 40 installs a version of the library that includes this code. However, when using SDK 41, people will need to use the latest version. To ensure that, I'll add the library to the list of libraries that we automatically update when running
expo upgrade.