Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Aug 7, 2025

What does this PR do?

Part of #3188

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3215.org.readthedocs.build/en/3215/

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69%. Comparing base (f24bbfc) to head (9b85fac).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3215   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         364     364           
  Lines       20073   20073           
======================================
  Hits        13788   13788           
  Misses       6285    6285           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the has conflicts label Aug 7, 2025
@mergify mergify bot removed the has conflicts label Aug 7, 2025
@Borda
Copy link
Collaborator Author

Borda commented Aug 7, 2025

@SkafteNicki split the split work on CPU and GPU and applied all your fixes...
But not sure why the older Torch version tests hang... :(

@Borda
Copy link
Collaborator Author

Borda commented Aug 7, 2025

seems that some test_rouge_score_class with DDP are hanging
ref: https://dev.azure.com/Lightning-AI/Metrics/_build/results?buildId=240099&view=logs&j=9d8f7376-3a6e-5f90-3b85-213e1b93299c

@Borda Borda marked this pull request as draft August 22, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants