dice score add warnings #3041
Merged
dice score add warnings #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isalia20
requested review from
SkafteNicki,
Borda and
justusschock
as code owners
2 tasks
|
PR for the release after this: Will require removing of the warning though which will be done after this is merged |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3041 +/- ##
========================================
- Coverage 70% 35% -35%
========================================
Files 357 343 -14
Lines 19736 19554 -182
========================================
- Hits 13841 6789 -7052
- Misses 5895 12765 +6870 🚀 New features to boost your workflow:
|
SkafteNicki
reviewed
Apr 7, 2025
There was a problem hiding this comment.
please also add a basic unit tests similar to this
https://github.com/Lightning-AI/torchmetrics/blob/c9e552e9496947483f181c4b89113e0207f212e1/tests/unittests/test_deprecated.py
|
Hi all, just checking in — what's the plan for this PR? @SkafteNicki @Borda |
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Borda
approved these changes
Apr 7, 2025
SkafteNicki
approved these changes
Apr 7, 2025
Borda
pushed a commit
that referenced
this pull request
May 27, 2025
* dice score add warnings * Apply suggestions from code review --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 12125c0)
Borda
pushed a commit
that referenced
this pull request
May 28, 2025
* dice score add warnings * Apply suggestions from code review --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 12125c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3031 for this release and then will be changed to
average=macrofor the next release📚 Documentation preview 📚: https://torchmetrics--3041.org.readthedocs.build/en/3041/